Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add referenceVar default support and namespace #148

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Oct 3, 2022

Description

add builderVarDefault support for a referenceVar field that allows the default for a prompt to be a previously supplied value from a previous prompt in the same series of prompts.

add namespace support across the deployment templates instead of just using the APPNAME or the default namespace every time

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Linux Integration Tests
  • Windows Integration Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

OliverMKing
OliverMKing previously approved these changes Oct 4, 2022
OliverMKing
OliverMKing previously approved these changes Oct 4, 2022
OliverMKing
OliverMKing previously approved these changes Oct 4, 2022
@davidgamero davidgamero merged commit e3fffe3 into main Oct 4, 2022
@davidgamero davidgamero deleted the referencevar-default branch October 4, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants