Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm namespace bugfix #183

Merged

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Feb 15, 2023

Description

Enforce helm namespace in deployment yaml

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Existing integration tests pass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@davidgamero davidgamero enabled auto-merge (squash) February 15, 2023 21:57
@davidgamero davidgamero merged commit f800623 into Azure:main Feb 15, 2023
aamgayle pushed a commit to aamgayle/draft that referenced this pull request Mar 23, 2023
@davidgamero davidgamero deleted the davidgamero/helm-namespace-bugfix branch April 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants