test: Refactor workload orchestration E2E part 1 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
3 times, most recently
from
f3ad7c6
to
8d4f85b
Compare
|
I have refactored the helper methods and added another test, just noticed this comment wanted an individual PR for refactor my bad @zhiying-lin |
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
1d5ac25
to
c50ecc2
Compare
zhiying-lin
reviewed
Sep 15, 2022
zhiying-lin
reviewed
Sep 19, 2022
1 task
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
75d354b
to
22182ff
Compare
|
The join_leave_placement_test.go test is flaky even after removing the Ordered flag, it fails rarely but it fails Alternative: would be place this test in it's own test suite |
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
e9b9744
to
421dae0
Compare
|
@zhiying-lin Addressed comment #303 (comment) by adding helper methods for checking MemberCluster and InternalMemberCluster Status |
Arvindthiru
commented
Sep 29, 2022
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
78bb475
to
af48716
Compare
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
af48716
to
0638c8f
Compare
zhiying-lin
reviewed
Sep 29, 2022
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
285c978
to
c808c87
Compare
zhiying-lin
reviewed
Oct 9, 2022
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
c808c87
to
9052173
Compare
Arvindthiru
force-pushed
the
WorkloadE2ERefactor1
branch
from
794a890
to
1073968
Compare
zhiying-lin
previously approved these changes
Oct 18, 2022
ryanzhang-oss
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Also Fixes #325
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
E2E test for workload orchestration
Special notes for your reviewer
Rebased and split this PR #248, Refactor and one new test case