Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: E2E for Work creation with CRD Object #288

Merged
merged 19 commits into from
Sep 27, 2022
Merged

test: E2E for Work creation with CRD Object #288

merged 19 commits into from
Sep 27, 2022

Conversation

aagusuab
Copy link
Member

Description of your changes

Fixes #

  • The test created covers the following scenarios:
    • Work with multiple objects
    • Creation of CRD object using Work
    • A Manifest that depends on another manifest within same work
      • There's a CRD object and the CR Object (of that CRD) in a work

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

zhiying-lin
zhiying-lin reviewed Sep 14, 2022
View reviewed changes
test/e2e/utils/helper.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Show resolved Hide resolved
zhiying-lin
zhiying-lin reviewed Sep 20, 2022
View reviewed changes
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
@aagusuab aagusuab force-pushed the new-crd-e2e branch 2 times, most recently from 579f70a to 81d4f49 Compare September 26, 2022 19:04
zhiying-lin
zhiying-lin reviewed Sep 27, 2022
View reviewed changes
test/e2e/utils/helper.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Show resolved Hide resolved
test/e2e/work_api_e2e_test.go Outdated Show resolved Hide resolved
zhiying-lin
zhiying-lin approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@zhiying-lin zhiying-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, others LGTM

@aagusuab aagusuab merged commit 3d829c0 into Azure:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanzhang-oss ryanzhang-oss ryanzhang-oss left review comments

@zhiying-lin zhiying-lin zhiying-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aagusuab @zhiying-lin @ryanzhang-oss