Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make each manifest applied reason clear #323

Merged
merged 2 commits into from
Sep 29, 2022
Merged

feat: make each manifest applied reason clear #323

merged 2 commits into from
Sep 29, 2022

Conversation

ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Sep 28, 2022 •
edited
Loading

Description of your changes

  1. Fix the case that the manifest applied condition says the "appliedManifestComplete" instead of "ManifestCreated" when we first create the manifest.
  2. Adjust the reason for other conditions accordingly
  3. Adjust UT

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

UT

Special notes for your reviewer

@Fei-Guo Fei-Guo merged commit cfb41a1 into Azure:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@circy9 circy9 Awaiting requested review from circy9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanzhang-oss @Fei-Guo