-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initial load test #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, can we specify the test length (e.g, the total number of created CRP crs) and report the metrics result in the end. Hence the test can be used as a benchmark.
Good idea to have a test length. It turned out that getting metrics with Prometheus client go lib is not easy (especially with the histogram). It's a lot easier to curl the metrics endpoint. |
I would suggest adding a few atomic_int variables to count the total number of CRP crs, the number of timeout crs, etc, and print out the result when the program exits, we don't need to dump the histogram. This should good enough for finding some critical issues. |
Description of your changes
Add a load test to measure the client-side latency for placement operations.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
I have run the test against fleet but hit a guard issue that prevent it from running more than 20 in parallel