feat: add v1beta1 flag to support v1beta1 controllers #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
force-pushed
the
v1beta1-support
branch
from
2d5911d
to
aee5a7c
Compare
zhiying-lin
force-pushed
the
v1beta1-support
branch
2 times, most recently
from
7e642e9
to
20d6292
Compare
michaelawyu
reviewed
Aug 14, 2023
michaelawyu
reviewed
Aug 14, 2023
zhiying-lin
force-pushed
the
v1beta1-support
branch
from
20d6292
to
1b79e03
Compare
zhiying-lin
force-pushed
the
v1beta1-support
branch
from
1b79e03
to
a3a8762
Compare
ryanzhang-oss
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
May need to add flag for the webhook too. It depends on the test result and could be added in a separate PR.