fix: only mark a binding apply failed if there are failed manifest #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
changed the title
zhiying-lin
reviewed
May 9, 2024
| return metav1.Condition{ | ||
| Status: metav1.ConditionFalse, | ||
| Type: string(fleetv1beta1.ResourceBindingApplied), | ||
| Reason: condition.WorkNotAppliedReason, |
There was a problem hiding this comment.
should we use "WorkFailedReason"?
| Status: metav1.ConditionFalse, | ||
| Type: string(fleetv1beta1.ResourceBindingApplied), | ||
| Reason: condition.WorkNotAppliedReason, | ||
| Message: fmt.Sprintf("Work object %s is not applied", notAppliedWork), |
There was a problem hiding this comment.
Suggested change
| Message: fmt.Sprintf("Work object %s is not applied", notAppliedWork), | |
| Message: fmt.Sprintf("Failed to apply work object %s", notAppliedWork), |
need to record the failedWork
| @@ -170,7 +170,7 @@ func TestBuildAllWorkAppliedCondition(t *testing.T) { | |||
| ObservedGeneration: 1, | |||
| }, | |||
| }, | |||
| "applied should be false if not all work applied to the latest generation": { | |||
| "applied should be known if not all work applied to the latest generation": { | |||
There was a problem hiding this comment.
Suggested change
| "applied should be known if not all work applied to the latest generation": { | |
| "applied should be unknown if not all work applied to the latest generation": { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently, we mark a binding failed if not all work are applied. This causes the CRP controller to try to fill in failed placement from work. So we only mark a binding apply failed if there are failed manifest, CRP condition won't change. This is probably also useful when we start to copy failed manifest to the binding.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer