feat: remove webhook flag #840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed validation for required webhook service name. We have a default webhook svc name fleetwebhook in options |
Arvindthiru
commented
May 29, 2024
| @@ -45,7 +45,7 @@ AKS_NODE_REGIONS=("westus" "northeurope" "eastasia") | |||
| AKS_NODE_SKUS=("Standard_A4_v2" "Standard_B4ms" "Standard_D8s_v5" "Standard_E16_v5" "Standard_M16ms") | |||
| AKS_SKU_COUNT=${#AKS_NODE_SKUS[@]} | |||
| # The number of clusters that has pre-defined configuration for testing purposes. | |||
| RESERVED_CLUSTER_COUNT=3 | |||
| RESERVED_CLUSTER_COUNT=${MEMBER_CLUSTER_COUNT} | |||
There was a problem hiding this comment.
Required change for local testing with more/less than 3 member clusters
zhiying-lin
reviewed
May 30, 2024
| if o.EnableWebhook && o.WebhookServiceName == "" { | ||
| errs = append(errs, field.Invalid(newPath.Child("WebhookServiceName"), o.WebhookServiceName, "Webhook service name is required when webhook is enabled")) | ||
| } | ||
|
|
||
| connectionType := o.WebhookClientConnectionType |
There was a problem hiding this comment.
you cannot remove this check. eg, user sets the webhookServiceName explicitly. In this case, we need to return the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer