fix: fix flaky ro webhook e2e test #873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
reviewed
Jul 9, 2024
| @@ -1201,7 +1201,7 @@ var _ = Describe("webhook tests for ResourceOverride UPDATE operations", Ordered | |||
| By("creating a new resource override") | |||
| ro1 := &placementv1alpha1.ResourceOverride{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: fmt.Sprintf("test-ro-%d", GinkgoParallelProcess()), | |||
| Name: ro1Name, | |||
There was a problem hiding this comment.
have you figured out which test is creating the RO at the same time? Could you please explain why you believe the PR will fix the issue?
zhiying-lin
reviewed
Jul 10, 2024
| ro1 := &placementv1alpha1.ResourceOverride{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: fmt.Sprintf("test-ro-%d", GinkgoParallelProcess()), | ||
| Name: fmt.Sprintf("test-create-ro-%d", GinkgoParallelProcess()), |
There was a problem hiding this comment.
i don't think this's the root cause. this create should always fail and ro cannot be created in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
For webhook failure, ensure both are selecting the same resource.
For already exists failure, there are only two places that use "test-ro" so differentiated the names so that they don't overlap. In one instance it should get denied when trying to create, while in the other it gets created and then deleted.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer