fix: Fix a few karpenter-core issues #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
changed the title
helayoty
reviewed
Oct 2, 2023
helayoty
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a few karpenter-core issues:
Turn off the garbagecolletor controller for now. This controller tries to delete machine cr if node is not shown up after 10 sec when machine is marked launched. The garbagecolletor controller will always throw errors when a new machine CR is created if the node object has not shown up in current implementation. I will have a follow up change to fix the garbagecolletor.
After registering the machine, always populate machine status.allocatable and status.capacity with node status. Otherwise, the machine status are initialized with instanceType info which are inconsistent with the actual node status. This leads to errors reported by consistency controller.
Remove populateInflight call. It is difficult to controller when the
node.kubernetes.io/instance-typeis added in the node object. Hence this function always report errors before the label is populated. We don't need this functionality in gpu-provisioner. Hence, remove the code to avoid confusing error logs.Remove unnecessary debug logs.