This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Remove unused build script option #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,6 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| build_clean= | |||
| build_root=$(cd "$(dirname "$0")/.." && pwd) | |||
There was a problem hiding this comment.
d_r [](start = 4, length = 3)
It would actually be so nice if this script would die a horrible death.
I think all the options handled by this script can be directly passed to cmake, isn't it. It seems this script is an extra abstraction layer that is not really necessary ...
There was a problem hiding this comment.
Totally agree, and I think that will happen in the not too distant future.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--clean' option intools/build.sh` wasn't doing anything, as @GrantEdwards pointed out in issue #120.