This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
User can specific simulate sample's message sending period #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darobs
reviewed
Dec 1, 2016
| @@ -190,7 +199,7 @@ static MODULE_HANDLE SimulatedDevice_Create(BROKER_HANDLE broker, const void* co | |||
|
|
|||
| static void * SimulatedDevice_ParseConfigurationFromJson(const char* configuration) | |||
There was a problem hiding this comment.
Should there be corresponding changes to FreeConfigurationFromJson?
| config.messagePeriod = period; | ||
| result = malloc(sizeof(SIMULATEDDEVICE_CONFIG)); | ||
| if (result == NULL) { | ||
| LogError("allocation of configuration failed"); |
There was a problem hiding this comment.
Free config.macAddress as well, please.
|
I'm sorry, @yuwzho, I noticed too late that this was a branch off of master, would you please make a pull request from develop? |
|
@darobs Sure, I will fix your comments and send a new pullrequest to the develop branch |
|
Open another one to develop branch and the new one already refers to this one. So close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulate sample always send a message every 10 seconds in currect time.
It is different with the BLE sample, which will make the "simlate" sample not simulate the BLE sample's behavior.