Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how-to-build-agent-code.md #64

Merged
merged 18 commits into from
May 24, 2021
Merged

Update how-to-build-agent-code.md #64

merged 18 commits into from
May 24, 2021

Conversation

ValOlson
Copy link
Contributor

Instructions on how to integrate the Device Update agent in customers existing solution

@ValOlson ValOlson requested a review from Nox-MSFT May 14, 2021 00:01
@ValOlson ValOlson requested a review from a team May 20, 2021 20:18
jw-msft
jw-msft reviewed May 21, 2021
View reviewed changes
SUPPORT.md Outdated Show resolved Hide resolved
Jerry-GeGarcia
Jerry-GeGarcia reviewed May 24, 2021
View reviewed changes
docs/agent-reference/how-to-build-agent-code.md

Before integrating the Device Update agent in your existing application or solution review the below concepts.

* Learn how the Device Update service will communicate with the device client using IoT Hub Plug and Play properties to orchestrate over-the-air update actions from [here](https://github.com/Azure/iot-hub-device-update/blob/main/src/agent/adu_core_interface/src/agent_workflow.c).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agent_workflow.c)

to be replaced by the diagrams Nox circulated recently, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the links we fine last week. I will double check what is wrong with them today. New images are part of this PR if you want to take a look.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see them, thanks Val!

Jerry-GeGarcia
Jerry-GeGarcia reviewed May 24, 2021
View reviewed changes
docs/agent-reference/how-to-build-agent-code.md Outdated

* [Source code](https://github.com/Azure/iot-hub-device-update/blob/main/src/agent/adu_core_interface/src/agent_workflow.c)

4.Actions returned from your application should be in this format so that the Device Update service can work with your application. Learn more about [plug and play format](https://docs.microsoft.com/azure/iot-hub-device-update/device-update-plug-and-play), and Device Update agent [workflow](https://github.com/Azure/iot-hub-device-update/blob/main/src/agent/adu_core_interface/src/agent_workflow.c).
Copy link

@Jerry-GeGarcia Jerry-GeGarcia May 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actions

"The result reported from your application ..." #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you!

shiyi-peng
shiyi-peng reviewed May 24, 2021
View reviewed changes
CONTRIBUTING.md Outdated
@@ -0,0 +1,11 @@
# Contributing code or documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have consolidated the changes here, combined with other changes in my recent PR, so feel free to remove it here to avoid conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will merge this PR soon!

@shiyi-peng shiyi-peng merged commit 9dcede3 into main May 24, 2021
shaeussler pushed a commit to PTW-Freiburg/iot-hub-device-update that referenced this pull request Feb 16, 2022
@ValOlson @shiyi-peng
Update how-to-build-agent-code.md (Azure#64)
b471b8c 
* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Added images

* Update how-to-build-agent-code.md

* Added images

* Update SUPPORT.md

* Contributing.md

* Update how-to-build-agent-code.md

* add changes for support.md

* Revert "add changes for support.md"

This reverts commit 8de2a55.

* add support.md

Co-authored-by: shiyi-peng <71347127+shiyi-peng@users.noreply.github.com>
Co-authored-by: Shiyi Peng <shiyipeng@microsoft.com>
@Nox-MSFT Nox-MSFT deleted the ValOlson-patch-6 branch March 2, 2022 14:20
shiyi-peng added a commit that referenced this pull request Aug 5, 2022
@shiyi-peng @ValOlson
@Nox-MSFT @nihemstr @jw-msft
Merging changes from public branch (#384)
a659ca4 
* Updates to Installed Criteria definition (Agent)

* Update import-update.md

* Bug 32483422: Update page 'How to run agent' with latest feedback (#39)

* Update our documentation from source of truth main.c

* Revision on PR feedback

* markdown nit

* Revision on suggested nits

* Update how-to-modify-the-agent-code.md (#53)

* Update how-to-run-agent.md (#52)

* Update how-to-run-agent.md

* Update how-to-build-agent-code.md

* Update how-to-run-agent.md

* Update how-to-run-agent.md

* Update how-to-build-agent-code.md

* Update how-to-run-agent.md

* Update how-to-build-agent-code.md

* Add 'adu' and 'do' user setup instruction.

Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com>
Co-authored-by: Nicholas Hemstreet <62158276+nihemstr@users.noreply.github.com>

* Update how-to-run-agent.md (#57)

* Update how-to-run-agent.md

* Update how-to-run-agent.md

* Update how-to-run-agent.md

* Update how-to-run-agent.md

* Update SUPPORT.md (#63)

* Update SUPPORT.md

* Update SUPPORT.md

* Update how-to-modify-the-agent-code.md (#65)

* Update how-to-modify-the-agent-code.md

* Update how-to-modify-the-agent-code.md

* Update how-to-modify-the-agent-code.md

* Add the file (#67)

* Update how-to-build-agent-code.md (#64)

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Added images

* Update how-to-build-agent-code.md

* Added images

* Update SUPPORT.md

* Contributing.md

* Update how-to-build-agent-code.md

* add changes for support.md

* Revert "add changes for support.md"

This reverts commit 8de2a55.

* add support.md

Co-authored-by: shiyi-peng <71347127+shiyi-peng@users.noreply.github.com>
Co-authored-by: Shiyi Peng <shiyipeng@microsoft.com>

* Update how-to-build-agent-code.md

* Update how-to-build-agent-code.md

* Update how-to-modify-the-agent-code.md

* Update how-to-modify-the-agent-code.md

* Removing all publish '.md' files

Removing all publish '.md' files per ask from Andrew as these are now maintained in the official Azure docs

* change version from 0.7.0-public-preview to 0.8.0-rc1-public-preview

* install DO deps with v0.7.0

* Task 34732610: (agent build) Pipeline Migration to 1ES (#89)

* arm32 build azr

* modify both yamls

* add back static analysis

* add comments

* modify amd64 yml

Co-authored-by: Val <60334494+ValOlson@users.noreply.github.com>
Co-authored-by: Nox-MSFT <55153324+Nox-MSFT@users.noreply.github.com>
Co-authored-by: Nicholas Hemstreet <62158276+nihemstr@users.noreply.github.com>
Co-authored-by: jw-msft <84477130+jw-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nox-MSFT Nox-MSFT Awaiting requested review from Nox-MSFT

@Jerry-GeGarcia Jerry-GeGarcia Awaiting requested review from Jerry-GeGarcia

@jw-msft jw-msft Awaiting requested review from jw-msft

@shiyi-peng shiyi-peng Awaiting requested review from shiyi-peng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ValOlson @Jerry-GeGarcia @shiyi-peng @jw-msft