Bug 30744239 RemoveInstalledCriteria does not remove all matched entries #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nox-MSFT
approved these changes
May 26, 2021
JeffMill
reviewed
May 26, 2021
| { | ||
| break; | ||
| } | ||
| // otherwise, keep going to remove duplicates | ||
| } |
There was a problem hiding this comment.
do we really want to serialize after every remove (line 500)? seems like it would be better to move 500-501 outside of the loop. the fact that the loop on 489 is going in reverse order seems to imply that is the intention.
There was a problem hiding this comment.
good point! I will be sure to address this. I am closing this PR and will replicate to align with repo/branching strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow RemoveInstalledCriteria to remove duplicates.
Add tests for removing all dups and not removing non-matching.
Add InstalledCriteriaPersistence RAII class and used it to remove ADUC_INSTALLEDCRITERIA_FILE_PATH on destruction to improve test isolation for tests that use PersistInstalledCriteria().
Update docs for RemoveInstalledCriteria with example json.
screenshot of doxygen:
