PowerShell cmdlet for calling ADU Import Update REST API #74

devlie · 2021-06-09T03:46:57Z

Updated AduUpdate.psm1 module to support Import Manifest v3.
Added AduImportUpdate.psm1 module to create import manifest and the import API input. It also uploads update artifacts to AzBlob for staging.
Added AduAzStorageBlobHelper.psm1 module to help with uploading files to AzBlob.
Added AduRestApi.psm1 module to call ADU Import Update REST API.
Merged the two READMEs into one so it will appear as soon as user load the directory in GitHub.
Updated READMEs with new instructions.

dpokluda · 2021-06-09T21:38:13Z

tools/AduCmdlets/AduAzStorageBlobHelper.psm1

@@ -0,0 +1,80 @@
+#
+# Azure Device Update for IoT Hub


I believe our official name is just "Device Update for IoT Hub". #Resolved

dpokluda · 2021-06-09T21:39:53Z

tools/AduCmdlets/AduAzStorageBlobHelper.psm1

+    }
+
+    $account = Get-AzStorageAccount -ResourceGroupName $ResourceGroupName -Name $StorageAccountName -ErrorAction Stop
+    $container = New-AzStorageContainer -Name $ContainerName -Context $account.Context -ErrorAction SilentlyContinue


This line is here to create container if it doesn't yet exist, correct? Don't you have to do out-null in case it already exists? #Resolved

dpokluda · 2021-06-09T21:41:18Z

tools/AduCmdlets/AduAzStorageBlobHelper.psm1

@@ -0,0 +1,80 @@
+#
+# Azure Device Update for IoT Hub
+# Powershell module for uploading file to Azure Storage Blob Container.


nit: I believe it's "PowerShell". #Resolved

dpokluda · 2021-06-09T21:48:23Z

tools/AduCmdlets/AduImportUpdate.psm1

@@ -0,0 +1,104 @@
+#
+# Azure Device Update for IoT Hub
+# Powershell module for creating and preparing update for import into Azure Device Update.


nit: I am not sure about the guidance but I am not sure whether we are officially allowed to use "ADU" or "Azure Device Update" terms. #WontFix

I think we'll be fine. Our hostname is already adu.microsoft.com

dpokluda · 2021-06-09T21:52:32Z

tools/AduCmdlets/AduRestApi.psm1

+
+    Write-Verbose $RequestBody
+
+    $response = Invoke-WebRequest -Uri $url -Method POST -Headers $headers -Body $RequestBody -Verbose:$VerbosePreference


Have you considered Invoke-RestMethod? #WontFix

I need access to the response headers. Invoke-RestMethod added -ResponseHeadersVariable but that's only available from PS6 and script currently requires min PS5.

dpokluda · 2021-06-09T21:55:28Z

tools/AduCmdlets/AduRestApi.psm1

+        [timespan] $Timeout = [timespan]::FromMinutes(30)
+    )
+
+    Write-Host "Waiting for import operation $operationId to complete " -NoNewline


nit: Could this be used for DELETE as well? #Resolved

dpokluda · 2021-06-09T21:55:56Z

tools/AduCmdlets/AduRestApi.psm1

+
+    if ($operation.Status -ne 'Succeeded')
+    {
+        Write-Error "Failed to import update."


Delete? #Resolved

dpokluda · 2021-06-09T21:57:21Z

tools/AduCmdlets/AduImportUpdate.psm1

+function New-AduImportUpdateInput
+{
+<#
+    .SYNOPSIS


Do we want to include .EXAMPLE for each of exported functions? #Resolved

JeffMill · 2021-06-10T00:14:20Z

companion bash script?

In reply to: 858184608

JeffMill · 2021-06-10T00:15:43Z

tools/AduCmdlets/AduAzStorageBlobHelper.psm1

+        $ContainerName,
+
+        # Skip connecting to Azure.
+        [switch] $SkipLogin


what does this do? Is the assumption that there's a cached connection already? If so, wouldn't 44-46 be a no-op? #WontFix

Skips connect-azaccount call. For e.g. to get ref to 2nd container, you can append -SkipLogin.

connect-azaccount doesn't know to cache anything, hence this switch.

JeffMill · 2021-06-10T00:16:35Z

tools/AduCmdlets/AduAzStorageBlobHelper.psm1

+    }
+
+    $account = Get-AzStorageAccount -ResourceGroupName $ResourceGroupName -Name $StorageAccountName -ErrorAction Stop
+    $container = New-AzStorageContainer -Name $ContainerName -Context $account.Context -ErrorAction SilentlyContinue


-ErrorAction SilentlyContinue

why silently continue? I realize that 51 will ultimately fail if this does, but you might mask the root cause of failure, no? #WontFix

new-azstoragecontainer throws error when container already exists.

JeffMill · 2021-06-10T00:18:52Z

looks like this uses azure blob storage, so bash might be out (although there is a "cifs" tool).

I think you might be better writing this all in python instead of powershell.

python is fine cross platform (I realize that PS core works cross platform, but outside of 98052 it's not as widely used), and azure storage has a python SDK

In reply to: 858184608

JeffMill · 2021-06-10T00:20:31Z

tools/AduCmdlets/README.md

+```
+
+## Bash Script
+


nit?: i prefer two doc files. If I'm using bash why should I wade through half of this document to find what I need? #Resolved

Added TOC.

GitHub would render README.md when user navigates to the directory. Having 2 readme files prevent that.

JeffMill

🕐

devlie · 2021-06-14T20:59:27Z

Sorry, out of scope for now.

In reply to: 858186558

Leo Lie added 2 commits June 8, 2021 16:40

bundle script implementation

5953ad3

update readme.md

3e63d24

devlie requested review from JeffMill, dpokluda and Nox-MSFT June 9, 2021 03:46

remove commented out code

f7126f2

dpokluda suggested changes Jun 9, 2021

View reviewed changes

JeffMill reviewed Jun 10, 2021

View reviewed changes

JeffMill requested changes Jun 10, 2021

View reviewed changes

devlie closed this Jun 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PowerShell cmdlet for calling ADU Import Update REST API #74

PowerShell cmdlet for calling ADU Import Update REST API #74

devlie commented Jun 9, 2021

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

devlie Jun 14, 2021

dpokluda Jun 9, 2021 •

edited by devlie

Loading

devlie Jun 14, 2021

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

JeffMill commented Jun 10, 2021 •

edited by devlie

Loading

JeffMill Jun 10, 2021 •

edited by devlie

Loading

devlie Jun 14, 2021

JeffMill Jun 10, 2021 •

edited by devlie

Loading

devlie Jun 14, 2021

JeffMill commented Jun 10, 2021 •

edited

Loading

JeffMill Jun 10, 2021 •

edited by devlie

Loading

devlie Jun 14, 2021

JeffMill left a comment

devlie commented Jun 14, 2021


		Write-Verbose $RequestBody

		$response = Invoke-WebRequest -Uri $url -Method POST -Headers $headers -Body $RequestBody -Verbose:$VerbosePreference

PowerShell cmdlet for calling ADU Import Update REST API #74

PowerShell cmdlet for calling ADU Import Update REST API #74

Conversation

devlie commented Jun 9, 2021

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

devlie Jun 14, 2021

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

devlie Jun 14, 2021

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

dpokluda Jun 9, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

JeffMill commented Jun 10, 2021 • edited by devlie Loading

JeffMill Jun 10, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

devlie Jun 14, 2021

Choose a reason for hiding this comment

JeffMill Jun 10, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

devlie Jun 14, 2021

Choose a reason for hiding this comment

JeffMill commented Jun 10, 2021 • edited Loading

JeffMill Jun 10, 2021 • edited by devlie Loading

Choose a reason for hiding this comment

devlie Jun 14, 2021

Choose a reason for hiding this comment

JeffMill left a comment

Choose a reason for hiding this comment

devlie commented Jun 14, 2021

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

dpokluda Jun 9, 2021 •

edited by devlie

Loading

JeffMill commented Jun 10, 2021 •

edited by devlie

Loading

JeffMill Jun 10, 2021 •

edited by devlie

Loading

JeffMill Jun 10, 2021 •

edited by devlie

Loading

JeffMill commented Jun 10, 2021 •

edited

Loading

JeffMill Jun 10, 2021 •

edited by devlie

Loading