Inherit uds permissions when unlinking #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avranju
previously approved these changes
Aug 2, 2018
edgelet/edgelet-http/src/unix.rs
Outdated
|
|
||
| debug!("settings permissions {:#o} for {}...", mode, path.as_ref().display()); | ||
| let prev = umask(mask); | ||
| defer! {{ umask(prev); }} |
There was a problem hiding this comment.
I am guessing this restores the current process's umask when this function returns? Nice.
There was a problem hiding this comment.
Yes. It's similar to go's defer. The macro creates a struct and implements Drop and calls the block given to the macro in the drop.
avranju
previously approved these changes
Aug 2, 2018
avranju
approved these changes
Aug 2, 2018
This was referenced Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edgelet, when unlinking an existing unix domain socket, we use the umask of the process to create the new socket. This doesn't work well for the edgelet, because we need different permissions for the workload and mgmt sockets.
This PR updates the flow for the
unixscheme to use the previous socket's mode when unlinking and creating the new socket.