-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #371: Allow optional subscriptionId
in creds
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoChilia
temporarily deployed
to
Automation test
November 21, 2023 10:08
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 23, 2023 06:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 24, 2023 05:01
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
had a problem deploying
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Error
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
had a problem deploying
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Failure
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:24
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:47
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
MoChilia
temporarily deployed
to
Automation test
November 27, 2023 03:48
— with
GitHub Actions
Inactive
YanaXu
approved these changes
Nov 27, 2023
If both |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will remove the mandatory requirement of
subscriptionId
increds
to solve #371.login/.github/workflows/azure-login-positive.yml
Lines 37 to 41 in 7acbecf
login/.github/workflows/azure-login-positive.yml
Lines 61 to 67 in 7acbecf
login/.github/workflows/azure-login-positive.yml
Lines 223 to 228 in 7acbecf
login/.github/workflows/azure-login-positive.yml
Lines 201 to 207 in 7acbecf
login/.github/workflows/azure-login-positive.yml
Lines 153 to 158 in 7acbecf
login/.github/workflows/azure-login-positive.yml
Lines 178 to 185 in 7acbecf
login/.github/workflows/azure-login-negative.yml
Lines 407 to 413 in 7acbecf
login/.github/workflows/azure-login-negative.yml
Lines 391 to 398 in 7acbecf
Validation for both
subscription-id
andallow-no-subscriptions
are missed:login/src/common/LoginConfig.ts
Lines 102 to 104 in 31435a1
If
subscription-id
is given, then set the subscription:login/src/Cli/AzureCliLogin.ts
Lines 129 to 131 in 31435a1
login/src/PowerShell/AzPSScriptBuilder.ts
Lines 106 to 108 in 31435a1
Negative test for login tenant-level account with subscription-id (no permission to subscriptions):
login/.github/workflows/azure-login-negative.yml
Lines 355 to 373 in 7acbecf