Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove data-explorer tf outputs & typo #69

Merged
merged 2 commits into from
Aug 4, 2022
Merged

remove data-explorer tf outputs & typo #69

merged 2 commits into from
Aug 4, 2022

Conversation

nicoleserafino
Copy link
Contributor

@nicoleserafino nicoleserafino commented Aug 3, 2022 •
edited
Loading

PR into Azure/mlops-v2

Checklist

I have:

  • read and followed the contributing guidelines

Changes

  • removed outputs from data-explorer terraform module to prevent failing when enable-monitoring is set to false
  • fixed typo in arguments of classical/python prep.py from enabling_monitoring to enable_monitoring

fixes #

@nicoleserafino nicoleserafino changed the title remove data-explorer tf outputs remove data-explorer tf outputs & typo Aug 4, 2022
@cindyweng cindyweng merged commit 1a48906 into main-jul31 Aug 4, 2022
@cindyweng cindyweng mentioned this pull request Sep 1, 2022
Merged
@cindyweng cindyweng deleted the monitoring-infra branch September 13, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyweng cindyweng cindyweng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoleserafino @cindyweng