Port HTTP agent ServiceClientOption to 1.x

[joshgummersall]

Ports functionality to 1.x from:
https://github.com/Azure/ms-rest-js/pull/403/files

[joshgummersall]

Hey @daviwil and @xirzec - I tested this over the weekend with the Bot Builder SDK and it looks good. Any chance we could get this change landed relatively soon? I'm happy to address any issues in this PR or the PR opened against master.

[xirzec]

LGTM

[ramya-rao-a]

@joshgummersall Is this related to the @azure/arm-botservice package? If so, we will soon be publishing an update for it which will use v2 of @azure/ms-rest-js package. In that case, would you still need this fix for v1 of @azure/ms-rest-js?

[joshgummersall]

It’s for https://github.com/microsoft/botbuilder-js.

[ramya-rao-a]

Thanks @joshgummersall

Any reason we cannot have the botbuilder-js project use v2 of @azure/ms-rest-js?

[joshgummersall]

There is more context in #402. It boils down to backwards compatibility concerns. I added this same functionality to 2.x here (#403) as well as it is desirable functionality in both versions. Unfortunately, we are simply not able to upgrade to 2.x.

[daviwil]

Changes look good, can you also update Changelog.md to mention the new feature?

[joshgummersall]

@daviwil all set.

[daviwil]

Thanks @joshgummersall!

[joshgummersall]

Thanks for the reviews! Much appreciated.

[joshgummersall]

@daviwil any luck with getting this published?

[daviwil]

Sorry for the delay, I've got to fix a problem with our release automation to get this out, will get back to that as soon as I take care of some other pressing issues.

[joshgummersall]

Thanks for the update. Looking forward to the release!

[daviwil]

2.1.0 and 1.9.0 are both out now. Thanks again for the PRs!

[joshgummersall]

Awesome, glad to contribute. Cheers!