Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt from OWL #31

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Rebuilt from OWL #31

merged 3 commits into from
Mar 16, 2021

Conversation

hammar
Copy link
Member

@hammar hammar commented Mar 5, 2021

No description provided.

Copy link
Contributor

@alinamstanciu alinamstanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Looks Good To Me

Copy link
Collaborator

@rszcodronski rszcodronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we remove the "extended Capability hierarchy" (new Sensors/Actuators) from this commit. These will be superseded by the work we are doing with the Capabilities, and I notice several that will not be defined how we are recommending with the new Capabilities sub-classes.

We can keep the existing ones and update the property name lastValue.

Copy link
Contributor

@akshayj-MSFT akshayj-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too

@hammar hammar merged commit 4fa65fe into master Mar 16, 2021
@hammar hammar deleted the feature-capability-updates branch June 8, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants