Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MacOS and self-hosted runner #91

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

YanaXu
Copy link
Collaborator

@YanaXu YanaXu commented Nov 15, 2023

The features in this PR:

  • Support MacOS
  • Support Self-Hosted Runner
    • Azure PowerShell Action will sequentially check which of the following directories can save the downloaded Azure PowerShell module:
      • default path:
        • windows: C:\Modules
        • linux: /usr/share
        • other OS: none
      • $RUNNER_TOOL_CACHE
        • Refer to this page for the description of RUNNER_TOOL_CACHE: The path to the directory containing preinstalled tools for GitHub-hosted runners.
      • the current workspace folder

The test has been done on below runners with azPSVersion values (latest, 9.7.0, 10.4.0, 11.0.0):

  • GitHub-hosted Runners:
    • ubuntu-latest
    • windows-latest
    • macos-latest
    • macos-11
    • macos-12
    • macos-13
  • Self-hosted Runners
    • windows
    • ubuntu

@YanaXu
Copy link
Collaborator Author

YanaXu commented Nov 16, 2023

Copy link
Collaborator

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

expect(process.env.PSModulePath).not.toEqual(prevPSModulePath);
});
test('setPSModulePath should throw for MacOS', () => {
process.env.RUNNER_OS = "Darwin";
expect(() => Utils.setPSModulePath()).toThrow();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reasons to remove this negative case.

@YanaXu YanaXu merged commit 7f8525f into Azure:master Nov 17, 2023
6 checks passed
@YanaXu YanaXu deleted the yanxu/macos branch November 17, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants