Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sending up metric for ds targets from rs for advanced mode #249

Merged
merged 8 commits into from
Aug 26, 2022

Conversation

gracewehner
Copy link
Contributor

@gracewehner gracewehner commented Aug 25, 2022

  • Add variable that's currently hardcoded to false to not add in the scrape config for sending the up metric in the replicaset for the advanced mode daemonset targets
  • Match addon behavior for which scrape targets are enabled by default for CI/CD MAC clusters

We will need to doc that kube_node_status_condition from kube-state-metrics can be used to see if the node is down instead of the up metric from the ds targets. Will add a task for this

@gracewehner gracewehner requested a review from a team as a code owner August 25, 2022 23:44
vishiy
vishiy previously approved these changes Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants