-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Story 95456 #227
User Story 95456 #227
Conversation
@grayzu @lonegunmanb @stemaMSFT The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TomArcherMsft, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TomArcherMsft, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Looks mostly good. One minor change.
@grayzu I think after Tom's change we're just waiting on the E2E test. Can you kick it off? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Are we good to merge this PR? |
@stemaMSFT The pattern with Mark/Zijie has been that once they both have verified the code, Zijie responds with LGTM (or similar) and Mark merges. Therefore, since Zijie has given his "LGTM" comment, I would think you're okay to merge. |
User Story 95456