AI Studio terraform templates #322
Conversation
|
@grayzu @stemaMSFT @lonegunmanb can someone take a look at this pr? |
|
@grayzu changes have been made. |
|
Looks good to me. |
|
@grayzu when can this be merged? |
|
@andyaviles121 please fix the issues with the PR. When it passes e2e tests we can merge. |
|
@lonegunmanb looks like this e2e is failing because of some sort of race condition or deadlock based on the logs. Can you take a look? |
|
@lonegunmanb have you had a chance to look over this pr? I'm not sure how to fix issues with the e2e check failure |
|
@lonegunmanb is the issue due to the reused resource names? Seems like the key vault is having issues being created. |
|
@stemaMSFT can you try to run the e2e test again? I added in a section to the azurerm provider to hopefully help with the key vault issues. |
|
@stemaMSFT Can you please help unblock this E2E build? This seems not triggerable on our side. We have several customers looking for these templates to be merged? Thanks! |
|
Sorry for letting this slip for a few weeks. Just kicked off those E2E tests. |
|
@andyaviles121 @deeikele @lonegunmanb we're still running into E2E test issues. |
There was a problem hiding this comment.
Hi @andyaviles121 @deeikele thanks for opening this pr and apology for this late response.
I've checked the error message:
Test_Quickstarts/quickstart/101-ai-studio 2024-06-14T00:35:53Z command.go:185: │ Key Vault Name: "tftemplatekeyvault"): performing CreateOrUpdate: vaults.VaultsClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="VaultAlreadyExists" Message="The vault name 'tftemplatekeyvault' is already in use. Vault names are globally unique so it is possible that the name is already taken. If you are sure that the vault name was not taken then it is possible that a vault with the same name was recently deleted but not purged after being placed in a recoverable state. If the vault is in a recoverable state then the vault will need to be purged before reusing the name. For more information about VaultAlreadyExists, soft delete and purging a vault follow this link https://go.microsoft.com/fwlink/?linkid=2147740."
I've left a review comment to solve this issue. @stemaMSFT
|
@andyaviles121 @lonegunmanb the e2e tests have failed again, could you take a look? |
|
@stemaMSFT seemed like the connection had an incorrect field. I removed it. Can you try the e2e test again? |
|
cc: @stemaMSFT @andyaviles121 I'm running the e2e tests now. |
|
cc: @grayzu, @stemaMSFT. @lonegunmanb @andyaviles121 This sample is failing in part because it doesn't adhere to the Contributor Guide requirements for Terraform samples. https://review.docs.microsoft.com/en-us/help/contribute/global-terraform-template?branch=main |
|
@TomArcherMsft I rewrote the files to match the contributor guide. Can you review and run the e2e tests? |
|
@andyaviles121 This looks good. Please change "output.tf" to "outputs.tf" and I'll run the e2e tests. Thanks. |
|
@TomArcherMsft done :) |
|
CC: @andyaviles121 @stemaMSFT @lonegunmanb I ran the e2e tests and it looks as though everything passes now: Can this PR be merged now? |
No description provided.