Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate webapps-deploy to OneDeploy #360

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

dannysongg
Copy link
Member

@dannysongg dannysongg commented Sep 1, 2023

NOTE: The changes in this PR are dependent on the following PR getting merged and released: microsoft/pipelines-appservice-lib#99. It contains the changes to the Kudu service library that webapps-deploy consumes.

This change is to move the webapps-deploy Github Action to the new OneDeploy API. It is designed to be backwards compatible with webapps-deploy@v2. Regardless, this should be released as webapps-deploy@v3 to ensure that no existing users are regressed. Usage of the new action will look something like this:

- name: Deploy to Azure Web App
  id: deploy-to-webapp
  uses: azure/webapps-deploy@v3
  with:
    app-name: ${{ env.AZURE_WEBAPP_NAME }}
    publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
    package: '*.war'
    type: (jar, war, zip, static)
    clean: (true, false)
    target-path: (i.e. /home/site/wwwroot/test, /home/site/wwwroot/test.war)
    restart: (true, false)

The onedeploy-test branch in my fork has the required node_modules and can be used to test these changes before the piplines-appservice-lib PR gets merged. The test build can be invoked with:

  - name: Deploy to Azure Web App
    id: deploy-to-webapp
    uses: dannysongg/webapps-deploy-ds@onedeploy-test

@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

src/actionparameters.ts Outdated Show resolved Hide resolved
src/actionparameters.ts Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
Copy link

@jvano jvano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@dannysongg dannysongg temporarily deployed to automation test October 5, 2023 21:15 — with GitHub Actions Inactive
@dannysongg dannysongg temporarily deployed to automation test October 5, 2023 21:15 — with GitHub Actions Inactive
@sgollapudi77 sgollapudi77 merged commit 3dc06f7 into Azure:master Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants