Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound RT #2 - Request Bound Refresh Token #3505

Merged
merged 95 commits into from
Feb 2, 2022
Merged

Bound RT #2 - Request Bound Refresh Token #3505

merged 95 commits into from
Feb 2, 2022

Conversation

hectormmg
Copy link
Member

@hectormmg hectormmg commented Apr 21, 2021 •
edited
Loading

This PR:

  • Adds stk_jwk attribute to auth code URL and token request body in AuthorizationCodeClient in order to request bound refresh tokens from ESTS
  • Adds an msal-browser sample to test refresh token binding
  • Extends AuthorizationCodeClient tests to include stkJwk in every test request

@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
4ba7234 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
4faeced 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
9e95250 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
1ec67f3 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
40bcdce 
…rary-for-js into dev
@hectormmg
Add KeyManager class
75ede54
@hectormmg
Add STK JWK to BaseAuthRequest
09ac0e7
@hectormmg
Add STK generation logic to common and browser
b8f8be0
@hectormmg
Update PublicClientApplication tests to mock out STK generation from …
1072952 
…Auth Code requests
@hectormmg
Undo msal-node-samples changes
c4c209d
@hectormmg
Move generateCnf from PopTokenGenerator to KeyManager
a80561c
@hectormmg
Refactor crypto key generation to use different key generation algori…
da24851 
…thm options for AT and RT PoP
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
1f95780 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' of github.com:AzureAD/microsoft-authentication-lib…
f12b309 
…rary-for-js into dev
@hectormmg
Merge branch 'dev' into bound-rt-stk
62288ce
@hectormmg
Add missing API from Crypto Interface to msal-node
20d70ab
@hectormmg
Fix linter issues
fbfbe3e
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package samples Related to the samples apps for the library. labels Apr 21, 2021
@hectormmg hectormmg changed the title Refresh Token Binding #2: Request Bound Refresh Token Bound RT #2: Request Bound Refresh Token Apr 21, 2021
@hectormmg hectormmg changed the title Bound RT #2: Request Bound Refresh Token Bound RT #2 - Request Bound Refresh Token Apr 21, 2021
@hectormmg hectormmg mentioned this pull request Apr 22, 2021
Closed
@ghost
Copy link

ghost commented Nov 29, 2021

Reminder: The next release is scheduled for next week and this PR appears to be stale :(

If changes have been requested please address feedback.
If this PR is still a work in progress please mark as draft.

@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Nov 29, 2021
@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Dec 6, 2021
Base automatically changed from bound-rt-stk to refresh-token-binding January 28, 2022 22:53
@github-actions github-actions bot added the msal-node Related to msal-node package label Jan 28, 2022
tnorling
tnorling approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@tnorling tnorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, looks good otherwise. Given this is going into a staging branch I consider this non-blocking for now

@hectormmg hectormmg merged commit 160bacb into refresh-token-binding Feb 2, 2022
@hectormmg hectormmg deleted the bound-rt/acquire-bound-rt branch February 2, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonnutter jasonnutter jasonnutter approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag sameerag approved these changes

@pkanher617 pkanher617 Awaiting requested review from pkanher617

@bmahall bmahall Awaiting requested review from bmahall

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@samuelkubai samuelkubai Awaiting requested review from samuelkubai

Assignees
No one assigned
Labels
feature-pop msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hectormmg @codecov-commenter @jasonnutter @tnorling @sameerag