-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAD related changes in dataprotection aks ext CLI #263
AAD related changes in dataprotection aks ext CLI #263
Conversation
Draft currently, will raise after internal review and as per our required release timelines. |
Discussed pipeline test failures with Bavneet, the team is aware of this bug and working on it. |
src/k8s-extension/azext_k8s_extension/partner_extensions/DataProtectionKubernetes.py
Outdated
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/DataProtectionKubernetes.py
Outdated
Show resolved
Hide resolved
Reviewed. |
Final round of review and testing from Backup team is done For certain pipeline test failures, had pinged, @bavneetsingh16 that those are known issues and not regressed due to this PR extension team will take up fix in early january. Please let us know if there is any risk in merging/ releasing this around 15 January. |
cede7cd
into
AzureArcForKubernetes:k8s-extension/public
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.For Backup Team
Manual tests performed