Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAD related changes in dataprotection aks ext CLI #263

Conversation

anshulahuja98
Copy link

@anshulahuja98 anshulahuja98 commented Oct 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

For Backup Team

Manual tests performed

  • Install extension without specifying anything related to AAD-> verified populated useAAD true and SA Uri.
  • Install extension with useAAD = true -> verified populated useAAD true and SA Uri.
  • Install extension with useAAD = false -> verified populated useAAD false and SA Uri.
  • Update existing extension with useAAD and URI empty -> URI gets populated.
  • Update current extension with no new params -> URI populated.

@anshulahuja98
Copy link
Author

Draft currently, will raise after internal review and as per our required release timelines.
Merge ETA >1month

@anshulahuja98
Copy link
Author

Discussed pipeline test failures with Bavneet, the team is aware of this bug and working on it.
Test failures are unrelated to my code changes

@Miraj50
Copy link
Collaborator

Miraj50 commented Dec 26, 2023

Reviewed.

@anshulahuja98
Copy link
Author

Final round of review and testing from Backup team is done
We require this PR To be merged around 15 January.

For certain pipeline test failures, had pinged, @bavneetsingh16 that those are known issues and not regressed due to this PR

extension team will take up fix in early january.

Please let us know if there is any risk in merging/ releasing this around 15 January.

@bavneetsingh16 bavneetsingh16 enabled auto-merge (squash) January 22, 2024 18:58
@bavneetsingh16 bavneetsingh16 merged commit cede7cd into AzureArcForKubernetes:k8s-extension/public Jan 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants