Update BSC to compile with GHC 9.8.1 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by replacing uses of 'head' and 'tail' in files that promote warnings to errors. Newer GHC and core libraries give a warning on uses of these partial functions that fail when the input is an empty list. When these warnings elevated to errors, they prevented compilation, and those occurrences are addressed. Other occurrences still remain and will need to be resolved later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in a recent comment on issue #469, newer GHC and core libraries give a warning on uses of these partial functions that fail when the input is an empty list. Some files turn on
-Werrorto promote warnings to errors, causing compilation to fail. Those occurrences are addressed; others still remain and will need to be resolved later.