Add missing features to the {-# properties foo = {...} #-} syntax in Classic #626

nanavati · 2023-10-13T22:22:46Z

No description provided.

{-# properties mkFoo = {..} #-} syntax. Add a testcase that checks that the properties are applied even if a module is synthesized via the -g option. Also add expected Verilog output for mkPragmas.v from Pragmas test.

{-# properties mkFoo = {..} #-} syntax.

quark17 · 2023-10-14T00:00:50Z

Thank you again! I'm happy to merge this when the checks finish. A couple observations, though:

I was confused why you were comparing the Verilog for mkSynthesize, but it dawned on me that you need something to confirm that the module was synthesized (and decided to do that check this way?). Maybe a comment would avoid the risk of someone in the future removing that comparison, thinking that it was unnecessary (as I did).

Also, FYI, BSV module attributes for clock and reset are tested in bsc.mcd/Pragmas/ and bsc.names/portRenaming/moduleArgs/. I don't have a proposal for how we could better organize the tests (to not be in multiple places and asymmetric between BH and BSV), so this current structure is fine. The BSV tests are mostly testing behavior, so it's OK for the BH tests to just focus on syntax.

nanavati · 2023-10-17T17:03:08Z

Added a comment about the mkSynthesize.v comparison.

nanavati added 2 commits October 13, 2023 15:21

Support the full range of Verilog pragmas in the Classic

b26a892

{-# properties mkFoo = {..} #-} syntax. Add a testcase that checks that the properties are applied even if a module is synthesized via the -g option. Also add expected Verilog output for mkPragmas.v from Pragmas test.

Support synthesize as a synonym for verilog in the

7db7cee

{-# properties mkFoo = {..} #-} syntax.

Add a comment on why we compare the Verilog output in a pragma test.

b66e048

quark17 merged commit 71eec9b into B-Lang-org:main Oct 17, 2023
33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing features to the {-# properties foo = {...} #-} syntax in Classic #626

Add missing features to the {-# properties foo = {...} #-} syntax in Classic #626

nanavati commented Oct 13, 2023

quark17 commented Oct 14, 2023

nanavati commented Oct 17, 2023

Add missing features to the {-# properties foo = {...} #-} syntax in Classic #626

Add missing features to the {-# properties foo = {...} #-} syntax in Classic #626

Conversation

nanavati commented Oct 13, 2023

quark17 commented Oct 14, 2023

nanavati commented Oct 17, 2023