Transfer the client_port to SocketDescriptor #15
Conversation
src/room_member.cpp
Outdated
| @@ -175,8 +175,7 @@ void RoomMember::ReceiveLoop() { | |||
| }; | |||
|
|
|||
| void RoomMember::Join(const std::string& nickname, const std::string& server, uint16_t server_port, uint16_t client_port) { | |||
| // TODO(Subv): Use client_port. | |||
| RakNet::SocketDescriptor socket; | |||
| RakNet::SocketDescriptor socket(client_port,""); | |||
|
Does this actually work? what is that client port used for? |
|
As stated in the RakNet documentation: The local port to bind to. Pass 0 to have the OS autoassign a port. |
src/room_member.cpp
Outdated
| @@ -175,7 +175,7 @@ void RoomMember::ReceiveLoop() { | |||
| }; | |||
|
|
|||
| void RoomMember::Join(const std::string& nickname, const std::string& server, uint16_t server_port, uint16_t client_port) { | |||
| RakNet::SocketDescriptor socket(client_port,""); | |||
| RakNet::SocketDescriptor socket(client_port, ""); | |||
There was a problem hiding this comment.
Most of the sample code uses 0 as second argument btw.
There was a problem hiding this comment.
I recognized that too. But in the documentation it states:
SocketDescriptor(unsigned short _port, const char *_hostAddress);
... Pass an empty string to use INADDR_ANY.
There was a problem hiding this comment.
I just checked the RakNet source code, and apparently 0 is the right way...
| @@ -175,8 +175,7 @@ void RoomMember::ReceiveLoop() { | |||
| }; | |||
|
|
|||
| void RoomMember::Join(const std::string& nickname, const std::string& server, uint16_t server_port, uint16_t client_port) { | |||
| // TODO(Subv): Use client_port. | |||
| RakNet::SocketDescriptor socket; | |||
| RakNet::SocketDescriptor socket(client_port, 0); | |||
There was a problem hiding this comment.
this is how it appears all over raknet source, I think we should keep as is and process them all together later [we can create an issue for it?]
There was a problem hiding this comment.
So internally RakNet checks if (hostAddress) /* With host address the second argument */
if false, it will assign hostAddress[0] = 0. Thus if hostAddress=nullptr this will fail...
We should stay with 0
There was a problem hiding this comment.
nullptr IS the same as 0 in this case. nullptr is (afaik) meant as a drop in replacement for NULL which is defined as #define NULL (void*)0.
However, I feel like we can go through and fix these later because we have so many other occurrences in the codebase. It's one of these: Don't turn a "haystack made out of needles" into "a haystack made of hay with just one needle".
There was a problem hiding this comment.
Thats right, but RakNet tries to set the value 0 to the memory area the nullptr is pointing to. Which will fail with a BAD_ACCESS error...
There was a problem hiding this comment.
Then it would also fail with the current code.
Note that it uses _hostAddress (the argument) to read from but moves to hostAddress (no underscore) which is the member variable.
No description provided.