Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the test cases for rake_new2 #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koolgax99
Copy link

@koolgax99 koolgax99 commented Jan 10, 2021

Description of the change

This is a fix to the issue #9 . In this I have added the edge cases for the rake_new2 module.
I have tried to add all the html tags in edge cases because the rake_new2 can take the HTML tags.

Related Issues

#9 Adding the edge cases for the rake_new2 module

What type of PR is this?

  • Adding tests to existing code

Added tests?

  • Yes

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #53 (f70fc32) into master (df045cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #53   +/-   ##
======================================
  Coverage    5.69%   5.69%           
======================================
  Files           5       5           
  Lines         123     123           
======================================
  Hits            7       7           
  Misses        116     116           
Flag Coverage Δ
unittests 5.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df045cd...f70fc32. Read the comment docs.

Copy link
Owner

@BALaka-18 BALaka-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the test cases once? Is each sentence a test case that didn't pass?

@koolgax99
Copy link
Author

@BALaka-18 there are 2 files in the test_cases folder.

edge_cases_file.txt this consists of all the edge cases I made, most of them work except a few(these are highlighted in the second file edge_cases_not_working.txt).

So the edge_cases_not_working.txt consists of edge cases which are not working as of now in the rake_new2 module.

@koolgax99
Copy link
Author

@BALaka-18 can you please review the pull request for the issue #9 . the competition is about to end, can you please merge the pr soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants