Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

equals() #7

Closed
BBBOMi opened this issue Jun 24, 2020 · 0 comments
Closed

equals() #7

BBBOMi opened this issue Jun 24, 2020 · 0 comments
Labels
step

Comments

@BBBOMi
Copy link
Owner

BBBOMi commented Jun 24, 2020 •
edited
Loading

  1. 해결하고자 하는 목표
    • Dollar와 Dollar를 직접 비교할 수 있다.

  1. 해당 이슈에서 한 작업
    • 우리의 디자인 패턴(value object pattern)이 하나의 또 다른 operation을 암시 한다는 것을 알았음.
    • 해당 operation을 테스트.
    • 해당 operation을 간단히 구현했음.
    • 곧장 리팩토링 하는 대신 테스트를 조금 더 추가.
    • 두 경우를 모두 수용할 수 있도록 리팩토링.
@BBBOMi BBBOMi added the step label Jun 24, 2020
BBBOMi added a commit that referenced this issue Jun 24, 2020
@BBBOMi
Test : equality를 확인하는 테스트 케이스 생성 #7
9d0547d
BBBOMi added a commit that referenced this issue Jun 24, 2020
@BBBOMi
Refactor : equality를 보장하기 위한 메서드 생성 #7
634db00 
테스트 케이스를 빠르게 통과하기 위해 무조건 true를 리턴하게 함.
BBBOMi added a commit that referenced this issue Jun 24, 2020
@BBBOMi
Refactor : 검증할 예제 추가 #7
9492e9b 
- 테스트 검증 실패 확인
BBBOMi added a commit that referenced this issue Jun 24, 2020
@BBBOMi
Refactor : equals 메서드 수정 #7
52f45aa 
- 테스트 케이스가 통과할 수 있도록 수정
This was referenced Jun 24, 2020
Open
Merged
@BBBOMi BBBOMi closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
step
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BBBOMi