Ensure that focusing visually hidden text doesn't jump to top of page #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble location on page
pjlee11
added
bug
ChrisBAshton
moved this from 2nd Code Review
to UX & Accessibility review
in News Article
bcmn
changed the title
|
Accessibility tested with a range of Category 1 & 2 software. Did not find any issues. |
|
LGTM |
|
Code Climate has analyzed commit 79b6be4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #869.
Adopts the CSS recommended by @greenc05 for VisuallyHiddenText, & updates snapshots to reflect.
Accessibility Testing
Reviewed with Catharine using voiceover for macOS. Separately reviewed using voiceover for iOS. Have not tested with NVDA/Chrome.