Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hash conflicts for pulses #234

Closed
wants to merge 1 commit into from
Closed

Avoid hash conflicts for pulses #234

wants to merge 1 commit into from

Conversation

dieris
Copy link
Collaborator

@dieris dieris commented Oct 8, 2019

Fix #77

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 58.081% when pulling dca600b on fix/hash-conflict into f282ca4 on develop.

@dieris
Copy link
Collaborator Author

dieris commented Oct 9, 2019

It turns out you can't pickle.dump a function... (stack_shapes) when the pulse shape results from a merge

QGL/QGL/Compiler.py

Lines 204 to 210 in f282ca4

def stack_shapes(entry1=entry1, entry2=entry2, **kwargs):
return np.hstack((
entry1.amp * np.exp(1j * entry1.phase) * entry1.shape,
entry2.amp * np.exp(1j * (entry1.frameChange + entry2.phase)) *
entry2.shape))
shapeParams['shape_fun'] = stack_shapes

@dieris
Copy link
Collaborator Author

dieris commented Oct 22, 2019

Closing for now

@dieris dieris closed this Oct 22, 2019
@grahamrow grahamrow deleted the fix/hash-conflict branch May 4, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-unique pulse key?
3 participants