Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/idle gatemod #284

Merged
merged 9 commits into from
Dec 14, 2021
Merged

Fix/idle gatemod #284

merged 9 commits into from
Dec 14, 2021

Conversation

ranzani
Copy link
Contributor

@ranzani ranzani commented Oct 21, 2021

In the old version any idle gate was creating a new NCO at zero frequency in the compiled sequence. Since the number of NCOs is limited, it looked like a waste. I modified it so that the idle gate simply reuses the frequency of the previous gate, without adding a new one.
I modified just the APS3 pattern for now, but if it works we can do it for the APS2.

@ranzani
Copy link
Contributor Author

ranzani commented Oct 22, 2021

It seems that the APS3 uses a different convention to select the NCO frequency. Instead of using a 4 bit register (0001 for nco 1, 0010 for nco 2, 0100 for nco 3,etc...) it just saves the nco number in binary format (0001 is nco 1, 0010 is nco 2, 0011 is nco 3 and 0100 is nco 4). As a result read_sequence_file was failing for more than 2 ncos. I fixed that as well.

This is assuming that the generated sequence is indeed in the correct format. I haven't tried testing it on the actual device to see if it works.

@ranzani ranzani merged commit d1bc6e2 into develop Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant