remove square pulse in favour of constant #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
square or rectangular make assumptions about what is before or after
| @@ -42,6 +33,8 @@ def constant(amp=1, length=0, samplingRate=1e9, **params): | |||
| numPts = np.round(length * samplingRate) | |||
| return amp * np.ones(numPts, dtype=np.complex) | |||
|
|
|||
| # square is deprecated but alias square to constant | |||
| square = constant | |||
There was a problem hiding this comment.
Makes we wish we had the equivalent of Julia's @deprecated macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names
squareorconstantmake assumptions about what is before or after and having a single pulse shape for "constant" pulses simplifies some TimeAmp checks. Leaving an alias fromsquare->constantshould silently update ChannelParams files.