Skip to content

Commit

Permalink
Remove unneeded tests, while the agents functions get redefined
Browse files Browse the repository at this point in the history
  • Loading branch information
@gdiazlo
gdiazlo committed Mar 19, 2019
1 parent 06b3e0d commit 57b4e88
Showing 1 changed file with 7 additions and 141 deletions.
148 changes: 7 additions & 141 deletions tests/e2e/agents_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"time"

"github.com/bbva/qed/hashing"
"github.com/bbva/qed/log"

"github.com/bbva/qed/protocol"
"github.com/bbva/qed/testutils/rand"
Expand All @@ -51,24 +52,6 @@ func getSnapshot(version uint64) (*protocol.SignedSnapshot, error) {
return s, nil
}

func getAlert() ([]string, error) {
alerts := make([]string, 0)
resp, err := http.Get(fmt.Sprintf("%s/alert", StoreURL))
if err != nil {
return nil, fmt.Errorf("Error getting alert from alertStore: %v", err)
}
defer resp.Body.Close()
alertsRaw, err := ioutil.ReadAll(resp.Body)
if err != nil {
return nil, fmt.Errorf("Error parsing alert from alertStore: %v", err)
}
err = json.Unmarshal(alertsRaw, &alerts)
if err != nil {
return nil, err
}
return alerts, nil
}

func TestAgentsWithoutTampering(t *testing.T) {
bStore, aStore := setupStore(t)
bServer, aServer := setupServer(0, "", false, t)
Expand All @@ -78,7 +61,7 @@ func TestAgentsWithoutTampering(t *testing.T) {

scenario, let := scope.Scope(t,
merge(bServer, bStore, bPublisher, bAuditor, bMonitor),
merge(aServer, aPublisher, aAuditor, aMonitor, aStore, delay(2*time.Second)),
merge(aServer, aPublisher, aAuditor, aMonitor, aStore),
)

event := rand.RandomString(10)
Expand All @@ -88,140 +71,23 @@ func TestAgentsWithoutTampering(t *testing.T) {
var ss *protocol.SignedSnapshot
var err error

client := getClient(t, 0)
client := getClient(0)

let("Add event", func(t *testing.T) {
snapshot, err = client.Add(event)
assert.NoError(t, err)
time.Sleep(2 * time.Second)
})

let("Get signed snapshot from snapshot public storage", func(t *testing.T) {
ss, err = getSnapshot(0)
retry(3, 1*time.Second, func() error {
ss, err = getSnapshot(0)
return err
})
assert.NoError(t, err)
assert.Equal(t, snapshot, ss.Snapshot, "Snapshots must be equal")
})

let("Check Auditor do not create an alert", func(t *testing.T) {
alerts, err := getAlert()
assert.NoError(t, err)
assert.True(t, len(alerts) == 0, "There should be no alerts")
})

let("Check Monitor do not create any alert", func(t *testing.T) {
alerts, err := getAlert()
assert.NoError(t, err)
assert.True(t, len(alerts) == 0, "There should be no alerts")
})

})

}

/* The following tests must be reworked alongside the gossip agents and
processors */

func TestAgentsDeleteTampering(t *testing.T) {
t.Skip()
bStore, aStore := setupStore(t)
bServer, aServer := setupServer(0, "", false, t)
bAuditor, aAuditor := setupAuditor(0, t)
bMonitor, aMonitor := setupMonitor(0, t)
bPublisher, aPublisher := setupPublisher(0, t)

scenario, let := scope.Scope(t,
merge(bServer, bStore, bPublisher, bAuditor, bMonitor),
merge(aServer, aPublisher, aAuditor, aMonitor, aStore, delay(2*time.Second)),
)

event := rand.RandomString(10)

scenario("Add 1st event. Tamper it. Check auditor alerts correctly", func() {
var err error

client := getClient(t, 0)

let("Add 1st event", func(t *testing.T) {
_, err = client.Add(event)
assert.NoError(t, err)
time.Sleep(2 * time.Second)
})

let("Tamper 1st event", func(t *testing.T) {
buff := strings.NewReader(fmt.Sprintf(`{"Digest": "%X"}`, hashing.NewSha256Hasher().Do(hashing.Digest(event))))
resp, err := doReq("DELETE", QEDTamperURL, APIKey, buff)
assert.NoError(t, err)
assert.Equal(t, resp.StatusCode, http.StatusOK, "Server should respond with http status code 200")
})

let("Check Auditor alerts", func(t *testing.T) {
time.Sleep(2 * time.Second)
alerts, err := getAlert()
assert.NoError(t, err)
assert.Truef(t, len(alerts) == 0, "Must exist auditor alerts: %v", alerts)
})

let("Check Monitor does not create any alert", func(t *testing.T) {
time.Sleep(1 * time.Second)
alerts, err := getAlert()
assert.NoError(t, err)
assert.Truef(t, len(alerts) == 0, "Must not exist monitor alert: %v", alerts)
})
})
}

func TestAgentsPatchTampering(t *testing.T) {
t.Skip()
bStore, aStore := setupStore(t)
bServer, aServer := setupServer(0, "", false, t)
bAuditor, aAuditor := setupAuditor(0, t)
bMonitor, aMonitor := setupMonitor(0, t)
bPublisher, aPublisher := setupPublisher(0, t)

scenario, let := scope.Scope(t,
merge(bServer, bStore, bPublisher, bAuditor, bMonitor),
merge(aServer, aPublisher, aAuditor, aMonitor, aStore, delay(2*time.Second)),
)

event := rand.RandomString(10)

scenario("Add 1st event. Tamper it. Add 2nd event. Check monitor alerts correctly", func() {
hasher := hashing.NewSha256Hasher()
tampered := rand.RandomString(10)
event2 := rand.RandomString(10)

client := getClient(t, 0)

let("Add 1st event", func(t *testing.T) {
_, err := client.Add(event)
assert.NoError(t, err)
time.Sleep(2 * time.Second)
})

let("Tamper 1st event", func(t *testing.T) {
buff := strings.NewReader(fmt.Sprintf(`{"Digest": "%X","Value": "%X"}`, hasher.Do(hashing.Digest(event)), hasher.Do(hashing.Digest(tampered))))
resp, err := doReq("PATCH", QEDTamperURL, APIKey, buff)
assert.NoError(t, err)
assert.Equal(t, resp.StatusCode, http.StatusOK, "Server should respond with http status code 200")
})

let("Add 2nd event", func(t *testing.T) {
_, err := client.Add(event2)
assert.NoError(t, err)
time.Sleep(2 * time.Second)
})

let("Check Auditor does create an alert", func(t *testing.T) {
alerts, err := getAlert()
assert.NoError(t, err)
assert.Truef(t, len(alerts) > 0, "Must exist auditor alerts: %v", alerts)
})

let("Check Monitor alerts", func(t *testing.T) {
alerts, err := getAlert()
assert.NoError(t, err)
assert.Truef(t, len(alerts) > 0, "Must exist monitor alert: %v", alerts)
})
})

}

0 comments on commit 57b4e88

Please sign in to comment.