CI: add python 3.8 testing #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK for adding python 3.8 testing but despite the py27 EOL, we should maintain ability to use that. The f strings can be converted. Any other incompatibilities with py27? |
prjemian
reviewed
May 27, 2020
prjemian
reviewed
May 27, 2020
prjemian
requested changes
May 27, 2020
|
Sad to hear you still want to support 2.7. There may be other things required to support it, but I didn't look into them. I'll push another commit re-adding it to CI in a bit. |
|
Thanks. |
klauer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing on Python 2.7 is failing as the codebase uses a considerable amount of f-strings. Removed that and added Python 3.8.