Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example: scaler v. motor using sscan record #940

Closed
prjemian opened this issue Mar 16, 2024 · 4 comments · Fixed by #942
Closed

New example: scaler v. motor using sscan record #940

prjemian opened this issue Mar 16, 2024 · 4 comments · Fixed by #942
Assignees
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Mar 16, 2024

  • set the scaler count time (SCALER.preset_time)
  • setup sscan record
    • number of points
    • motor (start, stop, step parameters)
    • time (as readback of positioner p4), to get timestamp of each step (sscan record feature!)
    • scaler channels
    • detector triggers
  • run the scan and wait for finish
  • get data as {signal_name, data_array}
    • Must coordinate signal names as assigned in the setup above.
  • report as bluesky event documents
@prjemian prjemian added this to the 1.6.19 milestone Mar 16, 2024
@prjemian
Copy link
Contributor Author

prjemian commented Mar 16, 2024

Note apstools.plans.sscan_support.sscan_1D() might need to be updated based on this issue. That's why it is here rather than bluesky_training repo.

@prjemian
Copy link
Contributor Author

Also take note of BCDA-APS/bluesky_training#248 which also has setup and scanning with sscan record (and other records, too).

@prjemian prjemian self-assigned this Mar 16, 2024
@prjemian
Copy link
Contributor Author

Not seeing such a document under Plans. Just the source code documentation.

@prjemian
Copy link
Contributor Author

Update of sscan_1D is not necessary for this issue.

But, it is worthwhile to replace (or create a new sscan_step_1d() plan that accepts a list of:

  • detectors
  • triggers
  • positioners (readback, setpoint, start, finish, npts or step)

and assigns them to sscan record channels, runs the scan, then posts the data to databroker with meaningful names (such as the examples here).

prjemian added a commit that referenced this issue Mar 17, 2024
prjemian added a commit that referenced this issue Mar 17, 2024
prjemian added a commit that referenced this issue Mar 17, 2024
prjemian added a commit that referenced this issue Mar 17, 2024
prjemian added a commit that referenced this issue Mar 17, 2024
prjemian added a commit that referenced this issue Mar 18, 2024
prjemian added a commit that referenced this issue Mar 18, 2024
prjemian added a commit that referenced this issue Mar 18, 2024
prjemian added a commit that referenced this issue Mar 18, 2024
prjemian added a commit that referenced this issue Mar 18, 2024
prjemian added a commit that referenced this issue Mar 20, 2024
prjemian added a commit that referenced this issue Mar 20, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas pushed a commit that referenced this issue Apr 12, 2024
MDecarabas added a commit that referenced this issue Apr 12, 2024
* Added edge_align plan for beam edge alignment

* Need to find a better way to check signal quality.

* Formatted using ruff

* small formatting changes

* removed unused stats import

* removed another unused import

* Added a check function that yields correct results

* intermediate commit saving progress

* finished try/except when bad signal is detected

* Fixed formatting

* Added scipy to environment.yaml & requirements.txt

* CI #909 switch to 'ruff'

* DOC #909 update release notes

* MNT #909 revise per 'ruff check'

* CI #909 update

* Bump davidslusser/actions_python_ruff from 1.0.0 to 1.0.1

Bumps [davidslusser/actions_python_ruff](https://github.com/davidslusser/actions_python_ruff) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/davidslusser/actions_python_ruff/releases)
- [Commits](davidslusser/actions_python_ruff@v1.0.0...v1.0.1)

---
updated-dependencies:
- dependency-name: davidslusser/actions_python_ruff
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* MNT #872 hoist from MPE devices

* TST #872 adjust for new hoist

* MNT #872

* MNT #872 refactor

* MNT #872 hoist utils

* DOC #912

* ENV #938 bump the minimum requirement

* DOC #932 update relase notes

* DOC #938 contribution from @sveseli

* MNT #914 setup.py --> pyproject.toml

* DOC #921 copyright year

* MNT #914

* Added edge_align function for beam edge alignment

* added scipy to pyproject.toml

* CI #909 switch to 'ruff'

* DOC badge

* DOC badge

* DOC #940 example scans with sscan record

* DOC #940 it's only a word ...

* DOC #940

* DOC #940 it's a demo, actually

* DOC #940

* DOC #940 convert the blocking call to st.wait()

* DOC #940 per review

* DOC #940 per review

* DOC #940 proofreading

* DOC #940 per review, remove the section with the polling loop

* DOC #940 new title

* DOC #940 more proofing

* DOC #940 clarify the default sscan record array size of 1,000

* DOC #940 refactor to polling loop. Show the recommended style in a details section.

* DOC #940

* Added put_complete=True to sensitivity value and unit for the SRS-570 Pre-amp.

* Added a test for the sensitivity_unit put_complete, and removed the put_complete from sensitivity_value.

* CI #955 move requirements file

* MNT #955 sphinx config

* DOC #955 re-arrange

* DOC #955 apply to lower-level pages

* DOC #955 add docs upload

* CI #955

* CI #955

* CI #955 wip

* CI #955

* CI #955

* DOC #917 release note

* DOC #957 merge overview into home page

* DOC #955

* DOC #955

* DOC #955

* DOC #955

* Added edge_align function for beam edge alignment

* Added edge_align function for beam edge alignment

* Added edge_align function for beam edge alignment

* DOC #909 update release notes

* DOC #932 update relase notes

* Added edge_align function for beam edge alignment

* CI #909 switch to 'ruff'

* DOC #955

* Fixed merge issue

* fixed unused import

* change for tests to pass

* Formatting changes

* Fixed repeated section

* Small formatting changes

* Small syntax change

* Added toolz & scipy to conf.py

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Codrea <ecodrea@nefarian.xray.aps.anl.gov>
Co-authored-by: Pete R Jemian <prjemian@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pete R Jemian <prjemian@users.noreply.github.com>
Co-authored-by: Mark Wolfman <canismarko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant