Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Sphinx failed to import labjack #901

Merged
merged 3 commits into from
Jan 3, 2024
Merged

BUG: Sphinx failed to import labjack #901

merged 3 commits into from
Jan 3, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Jan 2, 2024

@prjemian prjemian added the bug label Jan 2, 2024
@prjemian prjemian added this to the 1.6.18 milestone Jan 2, 2024
@prjemian prjemian self-assigned this Jan 2, 2024
canismarko
canismarko approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@canismarko canismarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little less readable, but if it makes Sphinx happy I think it's worth the trade-off. Still puzzles me why it complains, though.

@prjemian
Copy link
Contributor Author

prjemian commented Jan 2, 2024

I tired removing ophyd from the Sphinx mocks, same problem.

apstools/docs/source/conf.py

Lines 91 to 109 in d47c55a

autodoc_mock_imports = """
bluesky
dask
databroker
databroker_pack
epics
h5py
intake
numpy
openpyxl
ophyd
pandas
pint
psutil
pyRestTable
pysumreg
spec2nexus
xarray
""".split()

@prjemian prjemian mentioned this pull request Jan 3, 2024
Merged
@prjemian prjemian merged commit a5acafb into main Jan 3, 2024
11 of 13 checks passed
@prjemian prjemian deleted the 900-failed-to-import-labjack branch January 3, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canismarko canismarko canismarko approved these changes

Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
1.6.18
Development

Successfully merging this pull request may close these issues.

BUG: Failed to import apstools.devices.labjack.
2 participants
@prjemian @canismarko