Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interested students #1224

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Add Interested students #1224

merged 12 commits into from
Jul 16, 2024

Conversation

AravDe
Copy link
Contributor

@AravDe AravDe commented Jun 17, 2024

The issue has been fixed, including the part where if you add a student twice they get removed.

Fixes #1144

@AravDe AravDe changed the title Interested students Add Interested students Jun 17, 2024
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/static/js/minorAdminPage.js Outdated Show resolved Hide resolved
app/templates/admin/cceMinor.html Outdated Show resolved Hide resolved
app/templates/admin/cceMinor.html Outdated Show resolved Hide resolved
app/logic/minor.py Outdated Show resolved Hide resolved
Copy link

View Code Coverage

@@ -91,7 +91,8 @@ $(document).ready(function() {
url: `/addVolunteersToEvent/${eventId}`,
type: "POST",
data: {"selectedVolunteers": selectedVolunteers, "ajax": true},
success: function(s){
success:
function(s){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start the function on the same line as the key, like we do all of our other ones.

@BrianRamsay BrianRamsay merged commit 6f05132 into development Jul 16, 2024
5 checks passed
@BrianRamsay BrianRamsay deleted the interested_students branch July 16, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to manually add students to the Interested Students table in Minor Management
3 participants