Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Issue 64 add theme selection menu #76

Merged
merged 17 commits into from
Sep 26, 2021
Merged

Conversation

Toeffe3
Copy link
Member

@Toeffe3 Toeffe3 commented Aug 12, 2021

Purpose: Exploring theme selection options

Trying different methods to select theme color

Approach

Write css and rearrange HTML until a feasible design is acomplished

Testing steps to find bugs or errors in added code.

  1. Login
  2. Goto settings
  3. Press/drag icons/button/slider

@Toeffe3 Toeffe3 requested a review from a team as a code owner August 12, 2021 09:44
@Toeffe3
Copy link
Member Author

Toeffe3 commented Aug 12, 2021

Current behaviour: Slider snaps at defined key points - but has varying behaviours in different browsers.

Chrome: Snaps, but does only change colour PAST the mark - so dragging the slider to eg. Yellow it will still be orange, but by dragging a little further (not to the next snap-point) it changes, looks excellent:
billede

Firefox works as intended, but cannot handle marks or datalist, so visual is not ideal:
billede

Would be nice to have a combination of both, but behavior is not at all standardized.

@Andreasgdp Andreasgdp linked an issue Aug 12, 2021 that may be closed by this pull request
1 task
Copy link
Member

@Andreasgdp Andreasgdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a talk about this one. I thought we had agreed on having a theme selection window with preview items sort of like this example:
image

@Toeffe3 Toeffe3 marked this pull request as draft August 14, 2021 14:07
@Andreasgdp Andreasgdp marked this pull request as ready for review August 31, 2021 17:51
@Andreasgdp Andreasgdp marked this pull request as draft August 31, 2021 17:52
@Toeffe3 Toeffe3 marked this pull request as ready for review September 25, 2021 21:14
@Toeffe3
Copy link
Member Author

Toeffe3 commented Sep 25, 2021

API handles for theme should be made before any other changes can be implemented and tested

@Andreasgdp Andreasgdp marked this pull request as draft September 26, 2021 07:01
@Toeffe3 Toeffe3 marked this pull request as ready for review September 26, 2021 11:05
@Toeffe3 Toeffe3 enabled auto-merge (squash) September 26, 2021 11:17
@Andreasgdp Andreasgdp self-requested a review September 26, 2021 11:18
@Toeffe3 Toeffe3 merged commit ba0ac60 into master Sep 26, 2021
@Toeffe3 Toeffe3 deleted the issue-64-Add_theme_selection_menu branch September 26, 2021 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add theme selection menu
3 participants