Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two methods AdapterId with the exact same name and list of parameters #284

Closed
adecler opened this issue Feb 2, 2021 · 0 comments · Fixed by #290
Closed

Two methods AdapterId with the exact same name and list of parameters #284

adecler opened this issue Feb 2, 2021 · 0 comments · Fixed by #290
Assignees
@alelom
Labels
type:compliance Non-conforming to code guidelines
Milestone
BHoM 4.1 β RC

Comments

@adecler
Copy link
Member

adecler commented Feb 2, 2021

Broken rules:

The two methods below have the exact same name name and list of parameters so things like System.Type.GetMethod(string name, Type[] types) for example doesn't work.

public static object AdapterId(this IBHoMObject bHoMObject, Type adapterIdFragmentType)
public static T AdapterId<T>(this IBHoMObject bHoMObject, Type adapterIdFragmentType)
@adecler adecler added the type:compliance Non-conforming to code guidelines label Feb 2, 2021
@adecler adecler added this to the BHoM 4.1 β RC milestone Feb 2, 2021
This was referenced Feb 2, 2021
Merged
Merged
Merged
@alelom alelom mentioned this issue Feb 11, 2021
Closed
alelom added a commit that referenced this issue Feb 15, 2021
@alelom
Merge branch 'master' into BHoM_Adapter-#284-twoIdMethods
e005040
alelom added a commit that referenced this issue Mar 12, 2021
@alelom
Merge branch 'BHoM_Adapter-#284-twoIdMethods' of https://github.com/B…
d412f39 
…HoM/BHoM_Adapter into BHoM_Adapter-#284-twoIdMethods
@alelom alelom mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alelom alelom

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 4.1 β RC
2 participants
@alelom @adecler