Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter_Engine: Avoid signature duplication for AdapterId() methods #290

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Mar 15, 2021

PR replacing #287 due to merge conflicts.

See full description, commits and comments on #287.

Issues addressed by this PR

Closes #284
Closes #288

Test files

Needs testing of existing functionality on all Adapters.

Changelog

Additional comments

Due to merge conflicts. See version history on that PR.
#287
@alelom alelom self-assigned this Mar 15, 2021
@alelom alelom added the type:compliance Non-conforming to code guidelines label Mar 15, 2021
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2021

@IsakNaslundBh to confirm, check-installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

/azp run BHoM_Adapter.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh IsakNaslundBh merged commit f26581e into master Mar 23, 2021
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Adapter-#284-3-twoIdMethods branch March 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the Id query Two methods AdapterId with the exact same name and list of parameters
3 participants