Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop on Split(Polyline, cuttingLines) #3270

Closed
vietle-bh opened this issue Jan 30, 2024 · 3 comments · Fixed by #3283
Closed

Infinite loop on Split(Polyline, cuttingLines) #3270

vietle-bh opened this issue Jan 30, 2024 · 3 comments · Fixed by #3283
Labels
type:bug Error or unexpected behaviour

Comments

@vietle-bh
Copy link
Contributor

Description:

The prophecy has come true. My method managed to not run out of children 😅

while (children.Count > 0 && last == null) //while(last == null) risks an infinite loop if we never find the last node, we should eventually run out of children though

image

Steps to reproduce:

Expected behaviour:

Test file(s):

@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Jan 30, 2024
@vietle-bh
Copy link
Contributor Author

Hi @FraserGreenroyd , do you know who created this method and therefore knows best how to break this infinite loop?

@FraserGreenroyd
Copy link
Contributor

@vietle-bh this was made by @JohannaOlin1 and myself back in 2020/2021.

Can you upload some test files and we can take a look (or are you taking a look and just wanted to know who to ask for tips if needed?)? 😄

@vietle-bh
Copy link
Contributor Author

Thanks @FraserGreenroyd , it would be great to have this handled by the experts 😉
I'll create the test file and share it here Asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants