Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Clone Test Toolkit to be isolated further? #188

Closed
al-fisher opened this issue Mar 18, 2020 · 5 comments
Closed

CI Clone Test Toolkit to be isolated further? #188

al-fisher opened this issue Mar 18, 2020 · 5 comments
Assignees
Labels
type:question Ask for further details or start conversation

Comments

@al-fisher
Copy link
Member

There have been a couple of instances where the CI test fails as a result of the Clone Test Toolkit steps - rather than than the actual PR'd branches. Will be good to isolate further/version the Test Toolkit such that we do not get incompatible branch versions, giving I think false negative failures.

One to discuss @FraserGreenroyd

Recent example:

Failing Commit to oM here

can see state here:
image

Azure Job failing to build as part of Clone Test toolkit here

@al-fisher al-fisher added the type:question Ask for further details or start conversation label Mar 18, 2020
@al-fisher al-fisher added this to the BHoM 3.2 β MVP milestone Mar 18, 2020
@al-fisher
Copy link
Member Author

@alelom FYI

@FraserGreenroyd
Copy link
Contributor

@al-fisher I think BHoM did not receive the same updates to CI isolation that BHoM_Engine did when we were having difficulties there. I see the milestone is MVP of 3.2 so I presume there isn't anything holding up current work for close of this milestone?

@al-fisher
Copy link
Member Author

@al-fisher I think BHoM did not receive the same updates to CI isolation that BHoM_Engine did when we were having difficulties there. I see the milestone is MVP of 3.2 so I presume there isn't anything holding up current work for close of this milestone?

Yes - I wondered if it was a related issue.

I do not think there is anything urgent - the specific issue was resolvable by just updating all dependant PRs to master. But this ought to be unnecessary (assuming all the PRs are actually compatible amounts themselves)

Can pick up as part of 3.2

Thanks @FraserGreenroyd

@al-fisher
Copy link
Member Author

Had another odd one with AppVeyor too. Just noting here Fraser for us to do a general review in 3.2.
Ta
see BHoM/BHoM_UI#222

@FraserGreenroyd
Copy link
Contributor

So this has cropped up again this week, however, as we move towards utilising BHoMBot-CI more , I feel that this issue has been solved through isolating Test_Toolkit to nugets that work for the CI as opposed to conflicting between live builds. This means that the CI is version locked at run time, as opposed to being built every time it is needed, which is the current case with Azure.

As such, I feel this issue is being resolved through a natural evolution of CI operations, with our desired output for Azure to wind down and become a back up during the next couple of milestones. Thus I am going to close this issue on that basis, however if you feel this is the wrong answer then please do reopen 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Ask for further details or start conversation
Projects
None yet
Development

No branches or pull requests

2 participants