Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Types does not include DateTime #466

Closed
FraserGreenroyd opened this issue Feb 16, 2024 · 0 comments · Fixed by #467
Closed

System Types does not include DateTime #466

FraserGreenroyd opened this issue Feb 16, 2024 · 0 comments · Fixed by #467
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@FraserGreenroyd
Copy link
Contributor

The list of system types here for the IsExtensionMethod check does not include DateTime.

It also only includes string and not String, and does not perform a ToLower() operation on the parameter meaning we are enforcing methods with String foo input to be this String foo which isn't ideal.

This should be updated to:

  • Add DateTime to the excluded list
  • ToLower() the parameter type so the list can accurately check it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant