Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly and beta tests failing with --features="c" due to upstream bug #56

Closed
oconnor663 opened this issue Feb 7, 2020 · 3 comments
Closed

nightly and beta tests failing with --features="c" due to upstream bug #56

oconnor663 opened this issue Feb 7, 2020 · 3 comments

Comments

@oconnor663
Copy link
Member

rust-lang/rust#68905
@oconnor663 oconnor663 changed the title Nightly tests railing due to upstream bug Nightly tests failing due to upstream bug Feb 7, 2020
@oconnor663 oconnor663 mentioned this issue Feb 8, 2020
Closed
@oconnor663
Copy link
Member Author

It looks like nightly-2020-02-06 is the first compiler version with this issue. Anything prior to that should work.

@oconnor663
Copy link
Member Author

I've released version 0.1.5, which is a backport of af2e791. This should unbreak nightly builds of the blake3 crate with the default feature set. Only callers who enable the c_avx512 feature (which includes b3sum) will remain broken on nightly.

@oconnor663 oconnor663 mentioned this issue Feb 14, 2020
Closed
@oconnor663 oconnor663 pinned this issue Feb 28, 2020
oconnor663 added a commit to oconnor663/blake3-py that referenced this issue Mar 4, 2020
@oconnor663
pin an older nightly
56bf3d1 
This allows us to enable the underlying "c" feature, which is failing to
build on current nightlies. See related issues:

BLAKE3-team/BLAKE3#56
BLAKE3-team/BLAKE3#57
rust-lang/rust#68905
@oconnor663 oconnor663 mentioned this issue Mar 4, 2020
Closed
@oconnor663 oconnor663 changed the title Nightly tests failing due to upstream bug nightly and beta tests failing with --features="c" due to upstream bug Mar 13, 2020
@sneves sneves unpinned this issue Mar 22, 2020
@oconnor663
Copy link
Member Author

This is fixed as of rustc 1.44.0-nightly (38114ff16 2020-03-21) and rustc 1.43.0-beta.596 (1eaaee956 2020-03-22).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oconnor663