Account creation fails for user names with accented characters (Windows client)

[davidbolvansky]

My username: Dávid Bolvanský

Boinc (Windows) runs following RPC:
https://live.fitcrack.cz/fitcrack/create_account.php?email_addr=testmaixxl%40gmail%2Ecom&passwd_hash=8736ae7117ec1f3710627f22697f6f8c&user_name=D%E1vid%20Bolvansk%FD

and it fails:

<?xml version="1.0" encoding="ISO-8859-1" ?>
<br />
<b>Fatal error</b>:  Uncaught mysqli_sql_exception: Incorrect string value: '\xE1vid B...' for column 'name' at row 1 in /home/boincadm/projects/fitcrack/html/inc/db_conn.inc:69
Stack trace:
#0 /home/boincadm/projects/fitcrack/html/inc/db_conn.inc(69): mysqli-&gt;query()
#1 /home/boincadm/projects/fitcrack/html/inc/db_conn.inc(184): DbConn-&gt;do_query()
#2 /home/boincadm/projects/fitcrack/html/inc/boinc_db.inc(223): DbConn-&gt;insert()
#3 /home/boincadm/projects/fitcrack/html/inc/user_util.inc(126): BoincUser::insert()
#4 /home/boincadm/projects/fitcrack/html/user/create_account.php(134): make_user()
#5 {main}
  thrown in <b>/home/boincadm/projects/fitcrack/html/inc/db_conn.inc</b> on line <b>69</b><br />

Looks like 'Dávid Bolvanský' is in ISO-8599-1 and then urlencoded. If in utf8 and then urlencoded, 'D%C3%A1vid%20Bolvansk%C3%BD' works fine.

boinc/clientgui/ProjectProcessingPage.cpp

Line 408 in aabba28

ai->user_name = (const char*)::wxGetUserName().mb_str();

utf8_str ?

[AenBleidd]

Possible duplicate of #1503

[davidbolvansky]

I dont think so, as there is no xml here, just simple url request.

[AenBleidd]

Looks like both issues are related to database encoding that doesn't support UTF-8.
@davidpanderson, could you please take a look?

[davidbolvansky]

I have a working fix
#5025

[davidpanderson]

The MySQL default charset should be utf8mb4
We don't mention this in the docs.
E.g.:
MariaDB [test]> select @@character_set_database;
*************************** 1. row ***************************
@@character_set_database: utf8mb4
1 row in set (0.00 sec)

MariaDB [test]> select @@collation_database;
*************************** 1. row ***************************
@@collation_database: utf8mb4_unicode_ci

[davidbolvansky]

The MySQL default charset should be utf8mb4

Yeah, finally since MySQL 8.